[FEAT] Target SDK 35 대응 및 알람 해제 버튼을 통한 미션 진입 실패 버그 수정#244
Conversation
…l일 경우 홈 화면으로 이동하지 않도록 수정
WalkthroughAndroid의 Target SDK 버전이 34에서 35로 상향 조정되었습니다. 알람 관련 인텐트 및 브로드캐스트에 missionType, missionCount 파라미터가 추가되어 데이터 전달이 확장되었습니다. 여러 컴포저블 함수에서 시스템 바 패딩 및 레이아웃 구조가 개선되었고, 일부 함수 시그니처와 접근 제한자가 변경되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AlarmService
participant AlarmReceiver
participant AlarmInteractionActivityReceiver
participant MissionViewModel
User->>AlarmService: 알람 알림 생성
AlarmService->>AlarmDismissPendingIntent: missionType, missionCount 포함 인텐트 생성
AlarmDismissPendingIntent-->>AlarmService: PendingIntent 반환
User->>AlarmReceiver: 알람 DISMISS 액션 브로드캐스트
AlarmReceiver->>AlarmReceiver: notificationId, missionType, missionCount 추출
AlarmReceiver->>AlarmReceiver: 유효성 검사
AlarmReceiver->>AlarmReceiver: 브로드캐스트로 AlarmInteractionActivity 종료
AlarmReceiver->>AlarmInteractionActivityReceiver: notificationId, missionType, missionCount 포함 인텐트 전달
AlarmInteractionActivityReceiver->>MissionViewModel: 인텐트 파라미터 전달
MissionViewModel->>MissionViewModel: 미션 완료 처리 및 알람 dismiss 브로드캐스트
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20분 Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(해당 없음) Possibly related PRs
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (16)
💤 Files with no reviewable changes (1)
🧰 Additional context used🧠 Learnings (5)📓 Common learningscore/alarm/src/main/java/com/yapp/alarm/services/AlarmService.kt (1)Learnt from: DongChyeon core/alarm/src/main/java/com/yapp/alarm/AlarmConstants.kt (1)Learnt from: DongChyeon core/alarm/src/main/java/com/yapp/alarm/pendingIntent/interaction/AlarmDismissPendingIntent.kt (1)Learnt from: DongChyeon feature/mission/src/main/java/com/yapp/mission/MissionViewModel.kt (2)Learnt from: DongChyeon Learnt from: DongChyeon 🧬 Code Graph Analysis (6)feature/alarm-interaction/src/main/java/com/yapp/alarm/interaction/snooze/AlarmSnoozeTimerViewModel.kt (1)
feature/alarm-interaction/src/main/java/com/yapp/alarm/interaction/AlarmInteractionActivity.kt (2)
feature/alarm-interaction/src/main/java/com/yapp/alarm/interaction/action/AlarmActionViewModel.kt (1)
feature/alarm-interaction/src/main/java/com/yapp/alarm/interaction/action/AlarmActionScreen.kt (3)
feature/mission/src/main/java/com/yapp/mission/MissionViewModel.kt (3)
feature/alarm-interaction/src/main/java/com/yapp/alarm/interaction/snooze/AlarmSnoozeTimerScreen.kt (1)
🔇 Additional comments (29)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (4.25%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #244 +/- ##
============================================
- Coverage 4.27% 4.25% -0.03%
Complexity 53 53
============================================
Files 50 50
Lines 4421 4446 +25
Branches 647 649 +2
============================================
Hits 189 189
- Misses 4222 4247 +25
Partials 10 10
🚀 New features to boost your workflow:
|
1 participant
Related issue 🛠
closed #243
어떤 변경사항이 있었나요?
CheckPoint ✅
PR이 다음 요구 사항을 충족하는지 확인하세요.
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢
Summary by CodeRabbit
신규 기능
버그 수정
리팩터링
스타일